Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for tunnels to be ready (take 2) #488

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

royra
Copy link
Collaborator

@royra royra commented May 11, 2024

  • CTA: add state prop to /tunnels API endpoint. checks that all compose services have been started by docker, and that all potential tunnels for these services have been started by the CTA.
  • CLI: check new prop in up and urls commands. can be disabled with the --no-wait flag

Compatible with compose services which have no ports, e.g, one-off services such as DB init. Supersedes #479 which is not compatible with such services.

- CTA: add state prop to `/tunnels` API endpoint. checks that all compose services have been started by docker, and that all potential tunnels for these services have been started by the CTA.
- CLI: check new prop in `up` and `urls` commands. can be disabled with the `--no-wait` flag

Compatible with compose services which have no ports, e.g, one-off services such as DB init
@royra royra requested a review from Yshayy May 11, 2024 23:58
@royra royra merged commit 8e54df5 into main May 18, 2024
8 checks passed
@royra royra deleted the urls-wait-for-all-services-2 branch May 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants